Skip to content

⭐️ improve files.find resource#6297

Draft
chris-rock wants to merge 6 commits intomainfrom
chris-rock/filesfind
Draft

⭐️ improve files.find resource#6297
chris-rock wants to merge 6 commits intomainfrom
chris-rock/filesfind

Conversation

@chris-rock
Copy link
Copy Markdown
Member

@chris-rock chris-rock commented Dec 14, 2025

  • ⭐️ refactor code for easier readability
  • ⭐️ experimental local fs search that does not find command, which works also on Windows
  • ⭐️ support for powershell
  • 🐛 include depth argument in the resource id
  • 🧹 improve testing for find builder

Since this is quite a big change, I am going to split this into smaller PRs. This is here for reference that everything works together.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2025 •
edited
Loading

Test Results

4 697 tests  +16   4 693 ✅ +16   2m 41s ⏱️ +21s
  416 suites + 1       4 💤 ± 0 
   31 files   ± 0       0 ❌ ± 0 

Results for commit 1a4e2ee. ± Comparison against base commit 953f530.

This pull request removes 28 and adds 44 tests. Note that renamed tests count towards both. 
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestDepthMatcher
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestDepthMatcher/depth_0
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestDepthMatcher/depth_1
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestFindFiles
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestFindFilesMatcher
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestFindFilesMatcher/no_type_or_regex
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestFindFilesMatcher/no_type_or_regex/b_matcher
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestFindFilesMatcher/no_type_or_regex/c_matcher
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestFindFilesMatcher/no_type_or_regex/d_matcher
go.mondoo.com/cnquery/v12/providers/os/fs ‑ TestFindFilesMatcher/no_type_or_regex/f_matcher
…

go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestDepthMatcher
go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestDepthMatcher/depth_0
go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestDepthMatcher/depth_1
go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestFindFiles
go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestFindFilesMatcher
go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestFindFilesMatcher/no_type_or_regex
go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestFindFilesMatcher/no_type_or_regex/b_matcher
go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestFindFilesMatcher/no_type_or_regex/c_matcher
go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestFindFilesMatcher/no_type_or_regex/d_matcher
go.mondoo.com/cnquery/v12/providers/os/fsutil ‑ TestFindFilesMatcher/no_type_or_regex/f_matcher
…

♻️ This comment has been updated with latest results.

@chris-rock chris-rock force-pushed the chris-rock/filesfind branch 2 times, most recently from c1d5197 to 5521e76 Compare December 14, 2025 13:22
This was referenced Dec 14, 2025
Merged
Merged
@chris-rock
Copy link
Copy Markdown
Member Author

chris-rock commented Jan 15, 2026

The powershell change was merged here #6367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chris-rock